Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using sage-package to factor out common stuff #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nthiery
Copy link
Collaborator

@nthiery nthiery commented May 4, 2017

This adds a dependency. But is a step toward reducing the boilerplate in our packages by factoring it out in a single package. This also makes it easier to enhance that boilerplate to add new features (e.g. improvements to the Sphinx theme, which could include live doc support).

What do you think?

@nthiery nthiery requested review from embray, seblabbe and VivianePons May 4, 2017 13:48
@mmasdeu
Copy link

mmasdeu commented Jul 21, 2017

I hadn't realized that this existed. I made another package (called sagemath) in PyPI that has a similar purpose. In my branch this dependency already exists. Maybe one can merge both packages into a single one (and remove the other to avoid confusion). What are your thoughts? @nthiery @williamstein @mkoeppe @videlec ?

@embray
Copy link

embray commented Jul 21, 2017

@mmasdeu If there's a "sagemath" on PyPI that should be for the sagemath package itself, which at least one day will be on PyPI...

@williamstein
Copy link
Contributor

This sagemath PyPi package will be for the sagemath package itself, eventually. Right now it is a placeholder package, which when installed either works (since it’s installed into sage) or says something like “you must install sagemath from sagemath.org...”

@seblabbe
Copy link
Collaborator

I am currently at Sage Days 117. There was a demo earlier this week on how to share code and create a package where we used sage_sample. I am now taking a look at all the PR that have been here for years now...

No discussion has never been made about who should merge PRs.

The current PR has conflicts. I let the author or someone else fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants