Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using isinstance IntegralDomain in modules #38978

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

avoid using isinstance IntegralDomain in modules #38978

wants to merge 1 commit into from
+5 −5

Conversation

fchapoton
Copy link
Contributor

as a small step towards getting rid of the auld class IntegralDomain

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 2533390; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mantepse
mantepse approved these changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I'm pretty sure that the bot failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantepse mantepse mantepse approved these changes

Assignees
No one assigned
Labels
s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @mantepse