Disallow scaling of quaternion fractional ideals by zero #38963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also check in other tests that random scalars are nonzero
|
Documentation preview for this PR (built with commit ae698fb; changes) is ready! 🎉 |
GiacomoPope
reviewed
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disallows the scaling of quaternion fractional ideals by the zero element of the surrounding quaternion algebra (throwing a
ValueErrorin the process), as the result will by definition not be a fractional ideal. It also adds additional checks to avoid scaling by zero in other tests, which came up in the issue mentioned below, and it adds a missing warning for a long doctest.Fixes #38947.