Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow constructing elliptic curve from period lattice basis #38959

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Nov 12, 2024

As in the title.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#38474 because the input is approximate, so the output must be approximate, so we must support .period_lattice() on approximate elliptic curve first.

@user202729
Copy link
Contributor Author

user202729 commented Nov 12, 2024

Note that ModularFormElement already has an def __call__ that can take in value of q. But at the moment it doesn't work with numerical value… and I can't figure out how to extract the corresponding PARI object from the element, if even possible.

Copy link

Documentation preview for this PR (built with commit 3982816; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant