src/sage/env.py: don't pass if mismatched SAGE_ROOT is None #38935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait for CI, I haven't actually tried it |
|
Documentation preview for this PR (built with commit baecf8c; changes) is ready! 🎉 |
In this file we test that SAGE_ROOT in a subprocess is the same as SAGE_ROOT in the parent. There is a special case for when SAGE_ROOT is None, but that special case can pass if only one of the SAGE_ROOT variables is None and the other is not -- contrary to the intent of the test. Here we extend the special case to ensure that both SAGE_ROOT variables are None if one of them is. Thanks to Gonzalo Tornaría for the suggestion.
orlitzky
force-pushed
the
improved-subprocess-sage-root-test
branch
from
be1673c
to
baecf8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this file we test that
SAGE_ROOTin a subprocess is the same asSAGE_ROOTin the parent. There is a special case for whenSAGE_ROOT is None, but that special case can pass if only one of theSAGE_ROOTvariables isNoneand the other is not -- contrary to the intent of the test.Here we extend the special case to ensure that both
SAGE_ROOTvariables areNoneif one of them is.Thanks to Gonzalo Tornaría for the suggestion.