-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving "is_integrally_closed" to the category setup. #38927
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 8eaa9b9; changes) is ready! 🎉 |
src/sage/categories/rings.py
Outdated
sage: S.is_integrally_closed() | ||
True | ||
""" | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with the Sage category setup, but why isn't the default implementation to raise a NotImplementedError
? It looks like that was the previous behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, indeed, that's another possibility and that was the previous behaviour. We can also decide to say "False" if there is no specific reason known for the property in question to hold. I have no strong opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, indeed, that's another possibility and that was the previous behaviour. We can also decide to say "False" if there is no specific reason known for the property in question to hold. I have no strong opinion.
I feel that it's better to raise an error than report a potentially incorrect result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm overriding the needs-review bot. |
This is moving a method from the auld Ring class to the category setup.
📝 Checklist