Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving "is_integrally_closed" to the category setup. #38927

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

fchapoton
Copy link
Contributor

This is moving a method from the auld Ring class to the category setup.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Nov 5, 2024

Documentation preview for this PR (built with commit 8eaa9b9; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

sage: S.is_integrally_closed()
True
"""
return False
Copy link
Contributor

@vincentmacri vincentmacri Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the Sage category setup, but why isn't the default implementation to raise a NotImplementedError? It looks like that was the previous behaviour.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, indeed, that's another possibility and that was the previous behaviour. We can also decide to say "False" if there is no specific reason known for the property in question to hold. I have no strong opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, indeed, that's another possibility and that was the previous behaviour. We can also decide to say "False" if there is no specific reason known for the property in question to hold. I have no strong opinion.

I feel that it's better to raise an error than report a potentially incorrect result.

src/sage/categories/rings.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mantepse
Copy link
Collaborator

I'm overriding the needs-review bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants