Graph Plotting updates #38823
Open
Graph Plotting updates #38823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plots. In addition added label font sizes and allowed for shifting vertex labels when printing in a circular manner
|
Documentation preview for this PR (built with commit 929afc8; changes) is ready! 🎉 |
dcoudert
suggested changes
Oct 22, 2024
src/sage/graphs/graph_plot.py
Outdated
|
|
||
| estyle = self._options['edge_style'] | ||
| ethickness = self._options['edge_thickness'] | ||
| if style_key_edges is not None and ((style_key_edges and (x, y) in self._options['edge_styles']) or (not style_key_edges and lab in self._options['edge_styles'])): |
There was a problem hiding this comment.
please improve the alignment.
There was a problem hiding this comment.
What do you mean by the alignment? Do you mean for the if statement? Should I break it down so it's something like:
if (style_key_edges is not None
and ((style_key_edges and (x, y) in self._options['edge_styles'])
or (not style_key_edges and lab in self._options['edge_styles']))):
Or are you thinking something else?
There was a problem hiding this comment.
yes, this is much easier to read this way.
src/sage/graphs/graph_plot.py
Outdated
|
|
||
| estyle = self._options['edge_style'] | ||
| ethickness = self._options['edge_thickness'] | ||
| if style_key_edges is not None and ((style_key_edges and e in self._options['edge_styles']) or (not style_key_edges and elabel in self._options['edge_styles'])): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is handling a few different things all in one.
edge_styles,edge_thicknesses,label_fontsize, andvertex_label_shift. The first two options allow for users to specify individual styles/thicknesses for particular edges rather than a global one. The third one alters all font sizes. The final one shifts the vertex label when the layout iscircular.edge_thicknessand so I have fixed that instead.arrowsizecan be passed through. I double checked and the HTML docs do build (this was the reason it needed work)📝 Checklist
⌛ Dependencies
#28465
#21540
#22288