Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy species #38544

Draft
wants to merge 227 commits into
base: develop
Choose a base branch
from
Draft

Lazy species #38544

wants to merge 227 commits into from
+3,462 −6

Conversation

mantepse
Copy link
Collaborator

@mantepse mantepse commented Aug 21, 2024 •
edited
Loading

We provide an implementation of combinatorial species based on the lazy series framework and #38446.

dependencies: #38974

Newtech66 and others added 30 commits May 12, 2024 19:59
@Newtech66
Initial commit
8a5f1db
@Newtech66
Added _add_, _mul_, _element_constructor_ for group action input
ce7c87f
@Newtech66
Fixed bugs with caching and _mul_
2ae5497
@Newtech66
Improved repr output and added a way to name conjugacy classes of sub…
663b422 
…groups

Also added various miscellaneous functions
@mantepse
Merge branch 'develop' into burnside_ring
b3f16ba
@Newtech66 @mantepse
Update src/sage/rings/burnside.py
6f9cac4 
Co-authored-by: Martin Rubey <[email protected]>
@Newtech66
Doctest updates
bec9b0b
@Newtech66
Added ConjugacyClassesOfSubgroups
476218f
@Newtech66
Burnside ring now inherits from CombinatorialFreeModule
3d2a730 
Also some fixes to _element_constructor_ ConjugacyClassesOfSubgroups
@Newtech66
Changed category of Burnside ring to Algebras(base_ring).Commutative(…
d49eb76 
…).WithBasis()
@Newtech66
Implemented monomial() and one_basis()
bf76e0d 
Added _repr_ for ConjugacyClassesOfSubgroups
I now output B[(gens or name if available)] as _repr_ for generators, for example B[1] + 2*B[(2,3,4)]
@Newtech66
Add rename_gen
dc1d95d
@Newtech66
Add construct_from_action
c271e60
@Newtech66
Add _from_dict
1453c90
@Newtech66
Add product_on_basis and monomial_coefficients
fa8b9f5
@Newtech66
Remove ConjugacyClassesOfSubgroups from import
be11997
@Newtech66
Make indexes for generators use ConjugacyClassesOfSubgroups internall…
f39807c 
…y and doctest updates
@Newtech66
Add __eq__ for ConjugacyClassOfSubgroups so we can use it as dict key
d4af3fc
@Newtech66
Removed BurnsideRingElement and refactored code
de3ccbc
@Newtech66
Add __getitem__, minor doctest fix
d9e5aab
@Newtech66
Add __eq__ and minor fix in _normalize and set_name
1a377f5
@Newtech66
Implemented all suggested changes
45361c3
@Newtech66
Doctest additions
b8da0e6
@Newtech66
Doctest updates
ac4bb20
@Newtech66
Run doctest fixer
8ecf26d
@Newtech66
Small change
f617657
@Newtech66
Draft implementation of PolynomialMolecularDecomposition + other mino…
6ecbe83 
…r changes
@Newtech66
Added PolynomialMolecularDecomposition to imports
bd55d15
@Newtech66
Fixed __iter__ and added subset in ConjugacyClassesOfSymmetricGroupSu…
2ce14a5 
…bgroups
@Newtech66
Refactor conjugacy classes of subgroups of symmetric groups, add spec…
04ac9e9 
…ial case in construct_element
mantepse and others added 28 commits November 4, 2024 17:11
@mantepse @tscrim
Apply suggestions from code review
dd58ae3 
Co-authored-by: Travis Scrimshaw <[email protected]>
@mantepse
remove unnecessary else spotted by tscrim
8a15c61
@mantepse
implement _an_element_ instead of caching an_element as spotted by ts…
a305a74 
…crim
@mantepse
adapt doctest
cb5ef7b
@mantepse
do not use assert for input checking, spotted by tscrim
cd7b5a9
@mantepse
remove superfluous __init__ as spotted by tscrim
0bc0224
@mantepse
sort cover relations as str
580a5c2
@mantepse
more replacements of parent == self to parent is self
0ca9a5b
@mantepse
make MolecularSpecies.__classcall__ sane
4598eda
@mantepse
improve documentation
ade63cc
@mantepse @tscrim
Update src/sage/rings/species.py
727d4d2 
Co-authored-by: Travis Scrimshaw <[email protected]>
@mantepse @tscrim
Update src/sage/rings/species.py
ff604c8 
Co-authored-by: Travis Scrimshaw <[email protected]>
@mantepse @tscrim
Apply suggestions from code review
8d7ab18 
Co-authored-by: Travis Scrimshaw <[email protected]>
@mantepse
docfixes
622d08e
@mantepse
avoid recursion in _element_constructor_
9ef4cdb
@mantepse
Merge branch 'simple-species' into lazy-species
902df45
@mantepse
extract __call__ into separate class, proof of concept for special sp…
1d91d1e 
…ecies
@mantepse
fix bug in LazySpeciesElement.structures, add ProductSpeciesElement.s…
cbf8b1d 
…tructures
@mantepse
cosmetics
f4849ee
@mantepse
adapt doctest
92ba51f
@mantepse
preliminary support for generating structures of a composition
84086df
@mantepse
support incomparable labels
def85c5
@mantepse
Merge branch 'set_partitions/arbitrary_labels' into lazy-species
3c6159b
@mantepse
support left and right actions, default right
cf3cdf3
@mantepse
Merge branch 'species/left_and_right_actions' into lazy-species
a7ada76
@mantepse
provide structures for atomic and molecular species
b918066
@mantepse
simplify and correct structures
7af0ee8
@mantepse
try to make structures more predictable
10c90e0
@mantepse
Copy link
Collaborator Author

This is now mostly functional. The next decision is how to go about replacing the old species framework - @fchapoton, it would be great to have your input on this!

There is some functionality which is definitively missing. I know of the following:

  1. relabelling of structures
  2. generating isotypes
  3. the idea of SpeciesStructure, which provides a parent for structures and may make it easier to manipulate them
  4. functorial composition
  5. obtain a system of equations for a recursively defined species

1-3 are probably very easy, I think that 5 does not really belong to the species code, but should rather be a feature of the lazy framwork. Most likely, there is more.

More questions:

  • should we try to transfer the doctests into the new framework?
  • should we split the file into more components? If so, along which lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: combinatorics gsoc: 2024 Tag for GSoC2024 issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mantepse @Newtech66 @kwankyu