number_field_elements_from_algebraics: Fix CyclotomicField embedding when embedding=False #38441
+84
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 6c56c15; changes) is ready! 🎉 |
|
Something strange got merged into this PR: there are 3036 files changed with 80k+ lines of changes.... |
…when embedding=False
Co-authored-by: Travis Scrimshaw <[email protected]>
|
Looks like the merge commit go wrong. Should be fixed now. (the |
roed314
reviewed
Nov 8, 2024
src/sage/rings/qqbar.py
Outdated
| From: Number Field in zeta6 with defining polynomial x^2 - x + 1 | ||
| To: Algebraic Field | ||
| Defn: zeta6 |--> 0.500000000000000? + 0.866025403784439?*I) | ||
| sage: _[0].coerce_embedding() |
There was a problem hiding this comment.
I'm surprised that the underscore would work here. Even if it does, I think it's clearer to give the return value explicit names.
|
Looks good to me, other than the underscore comment. |
user202729
commented
Nov 8, 2024
|
Looks good to me. |
roed314
approved these changes
Nov 8, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 9, 2024
…icField embedding when embedding=False
Fixes sagemath#38440.
Uses `.coerce_embedding()` to determine the existence of the embedding
and modify the field accordingly, instead of doing what the code does
currently (assume the field is unembedded by default).
Note that there's a behavior change --- now when `embedding=False` it
will return a `NumberField` instead of `CyclotomicField` (even though it
is technically possible to create a `CyclotomicField(5,
embedding=None)`). I don't think this matters.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview. (only part that change is https://doc-pr-38441--sagemath.netlif
y.app/html/en/reference/number_fields/sage/rings/qqbar.html#sage.rings.q
qbar.number_field_elements_from_algebraics )
URL: sagemath#38441
Reported by: user202729
Reviewer(s): roed314, Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 13, 2024
…icField embedding when embedding=False
Fixes sagemath#38440.
Uses `.coerce_embedding()` to determine the existence of the embedding
and modify the field accordingly, instead of doing what the code does
currently (assume the field is unembedded by default).
Note that there's a behavior change --- now when `embedding=False` it
will return a `NumberField` instead of `CyclotomicField` (even though it
is technically possible to create a `CyclotomicField(5,
embedding=None)`). I don't think this matters.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview. (only part that change is https://doc-pr-38441--sagemath.netlif
y.app/html/en/reference/number_fields/sage/rings/qqbar.html#sage.rings.q
qbar.number_field_elements_from_algebraics )
URL: sagemath#38441
Reported by: user202729
Reviewer(s): roed314, Travis Scrimshaw, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38440.
Uses
.coerce_embedding()to determine the existence of the embedding and modify the field accordingly, instead of doing what the code does currently (assume the field is unembedded by default).Note that there's a behavior change --- now when
embedding=Falseit will return aNumberFieldinstead ofCyclotomicField(even though it is technically possible to create aCyclotomicField(5, embedding=None)). I don't think this matters.📝 Checklist