Add Infinite families of standard Cappell-Shaneson spheres #158
Conversation
|
Thank you! FYI, the "check" is here (linked in the box above). |
|
can you tell me more about checks, as i am new to this, like was I supposed to run those by ourself, if yes how can I do that in the future |
The whole point is to avoid merging changes, which break the build process. So, e.g. if the syntax is wrong or whatever, the python script processing it will fail. In this case here, the "check" runs that script, and the check passes if it does complete successfully. As an external contributor, someone who owns the repository has to active running the checks – that's what I did. Then the check ran with your change. There was no error. Then I merged it. If there would have been an error, you can see the error message. Then you're supposed to fix your code and push another commit. The check will run again. The definition of what's going on in the check is here – in particular the last line: https://github.com/sagemath/publications/blob/master/.github/workflows/check.yml |
|
that helps thanks |
fixes #155