Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include generated configure script in sdist #189

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Oct 7, 2023

Our 1.11.3 sdist on PyPI, generated for the first time by a GH Actions run, does not include the configure script.
See sagemath/sage#36402 (comment)

@mkoeppe mkoeppe self-assigned this Oct 7, 2023
@mkoeppe mkoeppe requested review from dimpase and malb October 7, 2023 17:42
@mkoeppe
Copy link
Author

mkoeppe commented Oct 7, 2023

@dimpase @malb Please review, merge & tag

@mkoeppe mkoeppe added this to the 1.11.4 milestone Oct 7, 2023
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So picking other targets for make makes sure ./configure is there?

OK, I presume you checked.

@dimpase dimpase merged commit 035ed16 into sagemath:main Oct 7, 2023
5 of 6 checks passed
@mkoeppe mkoeppe deleted the sdist_include_configure branch October 7, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants