Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/ci-sage.yml: Update to Docker push logic #164

Closed
wants to merge 2 commits into from

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Feb 2, 2022

We update the Docker push logic:

  • use what is implemented in tox.ini
  • prefix the package name with 'cysignals-' to avoid clashes with the packages pushed by Sage CI workflows
  • use latest or dev Docker tags for release tags

…e package name with 'cysignals-'; use 'latest' or 'dev' docker tags for release tags
@kliem
Copy link

kliem commented Jun 1, 2022

It seems that the CI-workflow is currently broken, see tests #166.

 ./bootstrap: 161: ./bootstrap: ./bootstrap-conda: not found
Bootstrap failed. Either install autotools and gettext; or run bootstrap with
the -d option to download the auto-generated files instead.

In general, I hardly understand what is going on in this workflow anymore.

@mkoeppe
Copy link
Author

mkoeppe commented Jun 1, 2022

This is fixed in https://trac.sagemath.org/ticket/33926

@kliem
Copy link

kliem commented Jun 1, 2022

I see, so no need to update here. Great.

@mkoeppe
Copy link
Author

mkoeppe commented Jun 3, 2022

I have merged #33926 into the ticket branch of the "CI target ticket for cysignals" #32579. So it will now be used by the workflow.

@mkoeppe
Copy link
Author

mkoeppe commented Sep 18, 2023

Outdated

@mkoeppe mkoeppe closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants