forked from microsoft/Megatron-DeepSpeed
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in main
from argonne-lcf/Megatron-DeepSpeed
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunspot frameworks tests
Fix path in `prof.export_chrome_trace()` from `pretrain_gpt_alcf.py`
…tron-DeepSpeed into tokenizer-tests
Merge in `tokenizer-tests` branch into `main`
…into hzheng-data-fix
…tron-DeepSpeed into hzheng-data-fix
Pull in changes from [6acc370](6acc370) to [`megatron/utils.py`](https://github.com/argonne-lcf/Megatron-DeepSpeed)
[merge]: into `microsoft-main` $\leftarrow$ from `hzheng-data-fix`
saforem2
commented
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Refactor the training script for improved logging and modularity, introduce new features such as support for additional optimizers and tokenizers, and enhance the data processing pipeline. Add new scripts for setting up and running training jobs on ALCF systems, and update documentation to reflect these changes.
New Features:
log
object from thelogging
module, replacing the previousprint_rank_0
calls for improved logging consistency.galore_adamw
,adafactor
, andadam8bit
, providing more flexibility in training configurations.Llama2Tokenizer
for handling specific tokenization needs.pretrain_llama.py
for pretraining Llama models, which includes setup for distributed training and logging with WandB.ALCF/helpers.sh
for setting up and launching training jobs on ALCF systems, including environment setup and job configuration.Bug Fixes:
get_ltor_masks_and_position_ids
function to ensure correct mask and position ID generation.torch
anddeepspeed
versions by updating the setup and installation scripts.Enhancements:
BuildConcatDataset
class for efficient dataset handling and concatenation.Build:
make_data
to ensure themegatron/data/helpers.cpp
is compiled before training.Deployment:
ALCF/README.md
to guide users on setting up and running training jobs on ALCF systems, including detailed instructions for different environments.Documentation:
Chores: