Skip to content

Commit

Permalink
Fix dangerous setting notification and add correction notice
Browse files Browse the repository at this point in the history
  • Loading branch information
dhaavi committed Aug 21, 2023
1 parent 278a059 commit 88b5c15
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion portmaster/notifications.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ notifications:
title: "Dangerous Setting: Incoming Connections"
message: |
You have disabled "Force Block Incoming Connections" globally. This allows incoming connections for every application by default. This is dangerous and we encourage you to enable this setting globally and then deactivate it for apps that need incoming connections.
match: "NumericVersion >= 9006 and Config.filter/blockInbound not == 7 and Config.core/expertiseLevel not sameas developer"
match: "NumericVersion >= 9006 and Config.filter/blockInbound exists and Config.filter/blockInbound not == 7 and Config.core/expertiseLevel not sameas developer"
type: 3 # Error
showOnSystem: true
repeat: 168h # 1 week
Expand All @@ -56,6 +56,13 @@ notifications:
payload:
Key: filter/blockInbound

dangerous-setting-global-allow-incoming-wrong-display:
title: "Wrong Warning - Sorry!"
message: |
Sorry for the wrong warning: Today we pushed an update to improve the "Dangerous Setting: Incoming Connections" warning for users who disabled "Force Block Incoming Connections" globally. This warning was incorrectly displayed to users whose settings where in good shape. We apologize for the confusion and will take care to test matching these conditions more thoroughly in the future.
match: "NumericVersion >= 9006 and Config.filter/blockInbound not == 7 and Config.core/expertiseLevel not sameas developer and Current.UTC.NumericDateTime < 20230821110000"
showOnSystem: true

release-channel-staging-warning:
title: "Using Staging Releases"
message: |
Expand Down

0 comments on commit 88b5c15

Please sign in to comment.