Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing singleton deployments #226

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Add missing singleton deployments #226

merged 1 commit into from
Oct 9, 2023

Conversation

@Uxio0 Uxio0 force-pushed the add-missing-deployments branch from 7f96330 to 2a5601c Compare September 8, 2023 14:29
@Uxio0 Uxio0 force-pushed the add-missing-deployments branch 3 times, most recently from 43d6503 to ee2a56f Compare September 28, 2023 12:17
@bertux
Copy link

bertux commented Sep 28, 2023

artifacts/10243/deployment.json Closes #232

@Uxio0 Uxio0 force-pushed the add-missing-deployments branch 2 times, most recently from 7c4967b to e7c1d12 Compare September 29, 2023 11:46
@dghelm
Copy link

dghelm commented Sep 29, 2023

Thanks for adding Scroll Sepolia artifact here!

Would it be possible to merge and publish a new npm package in the next week? We're hoping to get Safe Core contracts deployed to promote in the next ETHGlobal hackathon on Oct 6th 🤞

@bertux
Copy link

bertux commented Oct 1, 2023

I will mentor an hackathon in Madrid from October 7th to 8th so if we could get the updated npm package released to be able to deploy the contracts from this singleton it would help to get hackers try it.
While waiting for that, I will try a custom deployment to see if I can make it work first.
Thanks for your support.

@Uxio0 Uxio0 force-pushed the add-missing-deployments branch from e7c1d12 to 1c7cdbf Compare October 2, 2023 14:22
@Uxio0
Copy link
Member Author

Uxio0 commented Oct 2, 2023

Hi @bertux , I think the package that you need deployed is https://github.com/safe-global/safe-deployments and not this one

@Uxio0 Uxio0 requested review from akshay-ap and mmv08 October 6, 2023 10:30
@Uxio0
Copy link
Member Author

Uxio0 commented Oct 6, 2023

@mmv08 @akshay-ap I would like to merge this

@Uxio0 Uxio0 force-pushed the add-missing-deployments branch from 5b6be17 to 8e16c00 Compare October 6, 2023 14:55
- Closes #205
- Closes #206
- Closes #208
- Closes #212
- Closes #213
- Closes #214
- Closes #216
- Closes #218
- Closes #219
- Closes #220
- Closes #223
- Closes #224
- Closes #227
- Closes #232
- Closes #238
- Closes #237
@Uxio0 Uxio0 force-pushed the add-missing-deployments branch from 8e16c00 to 01f1b1c Compare October 6, 2023 15:01
@Uxio0 Uxio0 merged commit 0cb9114 into main Oct 9, 2023
@Uxio0 Uxio0 deleted the add-missing-deployments branch October 9, 2023 09:35
@mmv08 mmv08 mentioned this pull request Oct 19, 2023
@bertux
Copy link

bertux commented Jan 4, 2024

Hi @bertux , I think the package that you need deployed is https://github.com/safe-global/safe-deployments and not this one

Hello, I found later the problem was the naming of the package because it was still using the old naming with old versions and not the new one with the new versions. After updating the naming it found the new version without problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants