feat(transaction-builder-theme): Remove safe-react-components from transaction builder #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
clovisdasilvaneto
force-pushed
the
chore/normalize-tx-builder-theme
branch
from
7c79a60
to
0bead73
Compare
clovisdasilvaneto
force-pushed
the
chore/normalize-tx-builder-theme
branch
2 times, most recently
from
be186a1
to
23f5117
Compare
clovisdasilvaneto
force-pushed
the
chore/normalize-tx-builder-theme
branch
from
23f5117
to
6c43cbd
Compare
|
I have read the CLA Document and I hereby sign the CLA |
clovisdasilvaneto
changed the title
usame-algan
approved these changes
Oct 7, 2024
|
@usame-algan we can't because we still use some types of this package in the tx-builder. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
it solves the #820 but this PR should only be merged when #822 and #823 gets merged on this branch.
How this PR fixes it
It moves the icons from the safe-react-components repo to the transaction builder components folder in order to not use it from the achieved library anymore