Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing chains support #773

Closed
wants to merge 38 commits into from

Conversation

nick8319
Copy link
Contributor

@nick8319 nick8319 commented Feb 12, 2024

This PR is to add support for the following chains:
Blast Sepolia Testnet
Zora Mainnet & Sepolia Testnet
Mode Mainnet & Testnet
Optimism Sepolia Testnet
Unreal Testnet
Berachain Testnet
Holesky Ethereum Testnet
Zetachain Mainnet
Immutable Mainnet & Testnet & Devnet
Astar Shibuya & zKatana
Mantle Sepolia

Add safe-singleton addresses:
Linea Mainnet and Testnet
Scroll Mainnet and Testnet

nick8319 and others added 24 commits February 6, 2024 13:22
@nick8319 nick8319 requested a review from a team as a code owner February 12, 2024 08:21
@nick8319 nick8319 requested review from falvaradorodriguez, Uxio0 and hectorgomezv and removed request for a team February 12, 2024 08:21
@nick8319 nick8319 requested a review from a team as a code owner March 11, 2024 13:11
@Uxio0
Copy link
Member

Uxio0 commented Mar 22, 2024

Could it be posible?

  • To squash the commits
  • Provide the links to chainlist.org for the new added networks so we can check?

@moisses89
Copy link
Member

This PR is hard to follow multiple chains in one PR is not expected.
We have a new way to add chains and verify them here https://github.com/safe-global/safe-eth-py/issues/new?assignees=&labels=add-new-address&projects=&template=add_safe_address_new_chain.yml&title=%5BNew+chain%5D%3A+%7Bchain+name%7D
could you add this chains by the new process?

@Uxio0 Uxio0 closed this May 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants