Support multiple types of proxies #1380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Uxio0
commented
Oct 10, 2024
Uxio0
commented
- Until now, Safe only supported Safe Proxies
- Now ERC-1167 and ERC-1967 proxies are also supported
Pull Request Test Coverage Report for Build 11291868974Details
💛 - Coveralls |
- Until now, Safe only supported Safe Proxies - Now ERC-1167 and ERC-1967 proxies are also supported
Uxio0
force-pushed
the
implement-multiple-proxies
branch
from
3155116
to
50ec032
Compare
moisses89
approved these changes
Oct 11, 2024
| ) | ||
|
|
||
| @cache | ||
| def get_singleton_address( |
There was a problem hiding this comment.
Maybe we can or we would like to reuse this to other proxy implementations, could we call instead get_singleton_address call it as get_implementation_address?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.