Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename gnosis package name to safe_eth #1286

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Rename gnosis package name to safe_eth #1286

merged 4 commits into from
Aug 27, 2024

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez commented Aug 20, 2024 •
edited
Loading

Closes #1222

  • Updated the name of the gnosis package
  • Updated the packaging configuration.
  • Updated some mentions of Gnosis Safe to Safe only.
  • Updated sphinx doc.

@falvaradorodriguez falvaradorodriguez added the breaking_change Breaking change label Aug 20, 2024
@coveralls
Copy link

coveralls commented Aug 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10578554359

Details

  • 89 of 89 (100.0%) changed or added relevant lines in 36 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.892%
Totals Coverage Status
Change from base Build 10527711993: -0.01%
Covered Lines: 8670
Relevant Lines: 9234
💛 - Coveralls

@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review August 20, 2024 12:59
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner August 20, 2024 12:59
@falvaradorodriguez falvaradorodriguez changed the title Rename gnosis package name Rename gnosis package name to safe_eth Aug 20, 2024
@moisses89 moisses89 mentioned this pull request Aug 27, 2024
Draft
moisses89
moisses89 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I did a short test updating the dependency from github here.

@falvaradorodriguez falvaradorodriguez merged commit 211223b into main Aug 27, 2024
7 checks passed
@falvaradorodriguez falvaradorodriguez deleted the update-gnosis-package branch August 27, 2024 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
breaking_change Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename package name
3 participants
@falvaradorodriguez @coveralls @moisses89