Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make native balance optional for ERC20 get_balances #1216

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Make native balance optional for ERC20 get_balances #1216

merged 1 commit into from
Jul 16, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jul 16, 2024

@Uxio0
Make native balance optional for ERC20 get_balances
635cac0 
- Add a new optional parameter so native balance is not alway returned
- Closes #1199
@Uxio0 Uxio0 requested a review from a team as a code owner July 16, 2024 13:44
@coveralls
Copy link

coveralls commented Jul 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9958063397

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.003%) to 93.555%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/ethereum_client.py 1 86.16%
gnosis/safe/tests/utils.py 1 60.0%
gnosis/eth/clients/ens_client.py 1 59.38%
gnosis/safe/safe_tx.py 1 90.97%
Totals Coverage Status
Change from base Build 9955151509: 0.003%
Covered Lines: 8143
Relevant Lines: 8704
💛 - Coveralls

moisses89
moisses89 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uxio0 Uxio0 merged commit bf61b58 into main Jul 16, 2024
7 checks passed
@Uxio0 Uxio0 deleted the dont-return-native-balance branch July 16, 2024 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC20 get_balances should not return always the native balance
3 participants
@Uxio0 @coveralls @moisses89