Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC20 get_balances should not return always the native balance #1199

Closed
moisses89 opened this issue Jul 4, 2024 · 0 comments · Fixed by #1216
Closed

ERC20 get_balances should not return always the native balance #1199

moisses89 opened this issue Jul 4, 2024 · 0 comments · Fixed by #1216
Assignees
Labels
enhancement New feature or request

Comments

@moisses89
Copy link
Member

What is needed?

The current implementation is adding always the Native token balance when we get the erc20 balance.

# Add ether balance response

Possible solutions

  • Remove the Native token balance from the response of Erc20Manager.get_balance()
  • Add an optional parameter setting if we client wants to include the Native token balance or not.
@moisses89 moisses89 added the enhancement New feature or request label Jul 4, 2024
@Uxio0 Uxio0 self-assigned this Jul 16, 2024
@Uxio0 Uxio0 changed the title ERC20 GET balance should return just ERC20 balance ERC20 get_balances should not return always the native balance Jul 16, 2024
Uxio0 added a commit that referenced this issue Jul 16, 2024
- Add a new optional parameter so native balance is not alway returned
- Closes #1199
@Uxio0 Uxio0 closed this as completed in bf61b58 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants