Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auth-kit): Remove eth-testing package from auth-kit #828

Merged
merged 2 commits into from
May 28, 2024
Merged

chore(auth-kit): Remove eth-testing package from auth-kit #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e3ef46
Remove eth_testing package from auth-kit
yagopv May 27, 2024
8832523
Add yarn.lock
yagopv May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/auth-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"access": "public"
},
"devDependencies": {
"eth-testing": "^1.14.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
Expand Down
22 changes: 13 additions & 9 deletions packages/auth-kit/src/packs/safe-auth/SafeAuthPack.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
import { SafeAuthPack } from './SafeAuthPack'
import { generateTestingUtils } from 'eth-testing'
import { AuthKitBasePack } from '@safe-global/auth-kit/index'
import { SafeAuthInitOptions } from './types'
import { CHAIN_CONFIG } from './constants'

const testingUtils = generateTestingUtils({ providerType: 'MetaMask' })
const mockProvider = testingUtils.getProvider()
const mockProvider = {
request: async ({ method }: { method: string }) => {
if (method === 'eth_accounts') {
return Promise.resolve(['0xf61B443A155b07D2b2cAeA2d99715dC84E839EEf'])
}

if (method === 'eth_chainId') {
return Promise.resolve('0x1')
}

return null
}
}
const mockInit = jest.fn()
const mockLogin = jest.fn()
const mockLogout = jest.fn()
Expand Down Expand Up @@ -56,7 +66,6 @@ describe('SafeAuthPack', () => {

beforeEach(() => {
jest.clearAllMocks()
testingUtils.clearAllMocks()
mockInit.mockClear()
mockLogin.mockClear()
})
Expand Down Expand Up @@ -92,9 +101,6 @@ describe('SafeAuthPack', () => {

describe('signIn()', () => {
it('should call the login() method', async () => {
testingUtils.mockAccounts(['0xf61B443A155b07D2b2cAeA2d99715dC84E839EEf'])
testingUtils.mockChainId('0x1')

const authKitSignInData = await safeAuthPack.signIn()

expect(mockLogin).toHaveBeenCalled()
Expand All @@ -120,8 +126,6 @@ describe('SafeAuthPack', () => {
})

it('should return the provider after initialization', async () => {
testingUtils.mockAccounts(['0xf61B443A155b07D2b2cAeA2d99715dC84E839EEf'])

await safeAuthPack.init(safeAuthInitOptions)

expect(safeAuthPack.getProvider()).toEqual(mockProvider)
Expand Down
15 changes: 1 addition & 14 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2588,11 +2588,6 @@ [email protected]:
resolved "https://registry.yarnpkg.com/abitype/-/abitype-1.0.0.tgz#237176dace81d90d018bebf3a45cb42f2a2d9e97"
integrity sha512-NMeMah//6bJ56H5XRj8QCV4AwuW6hB6zqz2LnhhLdcWVQOsXki6/Pn3APeqxCma62nXIcmZWdu1DlHWS74umVQ==

abitype@^0.1.6:
version "0.1.8"
resolved "https://registry.npmjs.org/abitype/-/abitype-0.1.8.tgz"
integrity sha512-2pde0KepTzdfu19ZrzYTYVIWo69+6UbBCY4B1RDiwWgo2XZtFSJhF6C+XThuRXbbZ823J0Rw1Y5cP0NXYVcCdQ==

abitype@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/abitype/-/abitype-1.0.2.tgz#183c28f2f3b4278810ed1543941b555bb73f301d"
Expand Down Expand Up @@ -4232,14 +4227,6 @@ esutils@^2.0.2:
resolved "https://registry.npmjs.org/esutils/-/esutils-2.0.3.tgz"
integrity sha512-kVscqXk4OCp68SZ0dkgEKVi6/8ij300KBWTJq32P/dYeWTSwK41WyTxalN1eRmA5Z9UU/LX9D7FWSmV9SAYx6g==

eth-testing@^1.14.0:
version "1.14.0"
resolved "https://registry.npmjs.org/eth-testing/-/eth-testing-1.14.0.tgz"
integrity sha512-KRVSXHogM4byUUqoGlUK0ce3U4GsZcf/BAbY/L1LzMPPVntWfm12XQP3pxy0OPTSgvvP7sDGz41qifAZeVRUeQ==
dependencies:
abitype "^0.1.6"
ethers "^5.5.4"

[email protected], ethereum-cryptography@^0.1.3:
version "0.1.3"
resolved "https://registry.npmjs.org/ethereum-cryptography/-/ethereum-cryptography-0.1.3.tgz"
Expand Down Expand Up @@ -4326,7 +4313,7 @@ [email protected]:
tslib "2.4.0"
ws "8.5.0"

ethers@^5.5.4, ethers@^5.7.0, ethers@^5.7.1:
ethers@^5.7.0, ethers@^5.7.1:
version "5.7.2"
resolved "https://registry.npmjs.org/ethers/-/ethers-5.7.2.tgz"
integrity sha512-wswUsmWo1aOK8rR7DIKiWSw9DbLWe6x98Jrn8wcTflTVvaXhAMaB5zGAXy0GYQEQp9iO1iSHWVyARQm11zUtyg==
Expand Down
Loading