Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cli more inclusive #413

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Make cli more inclusive #413

merged 6 commits into from
Jun 13, 2024

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez commented Jun 12, 2024

Closes #319

The changes made are explained here.

The help messages are kept in white according to the article's indications. All other messages are in an appropriate colour.

Copy link

github-actions bot commented Jun 12, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@falvaradorodriguez
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jun 12, 2024
@coveralls
Copy link

Coverage Status

coverage: 87.033% (-0.1%) from 87.136%
when pulling 8ecd24e on make_cli_more_inclusive
into 29be0a2 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.033% (-0.1%) from 87.136%
when pulling b062113 on make_cli_more_inclusive
into 29be0a2 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.033% (-0.1%) from 87.136%
when pulling 95a5e07 on make_cli_more_inclusive
into 29be0a2 on main.

@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review June 12, 2024 19:40
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner June 12, 2024 19:40
args = parser.parse_args()
print_formatted_text(text2art("Safe Creator")) # Print fancy text
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moved so that the logo is not displayed when the --help and --version commands are executed.

Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work

@falvaradorodriguez falvaradorodriguez merged commit bebbba2 into main Jun 13, 2024
14 checks passed
@falvaradorodriguez falvaradorodriguez deleted the make_cli_more_inclusive branch June 13, 2024 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the CLI more inclusive
3 participants