Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix threshold retrieve in tx-service mode #410

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Jun 12, 2024

Description

When the safe-cli is running on ts-service mode the threshold was wrongly updated to the new value during a change_threshold command call.
The issue was that the function prepare_and_execute_transaction is overwritten by the SafeTxOperator class with the difference that instead execute the transaction in blockchain, the overwritten function POST the transaction to the Safe Transaction Service without execute it.

Proposal solution

Update from blockchain the threshold value.

Related issue

Closes #323

@moisses89 moisses89 force-pushed the fix_reload_threeshold branch 2 times, most recently from efa6f28 to 70133fb Compare June 12, 2024 11:54
@moisses89 moisses89 marked this pull request as ready for review June 12, 2024 11:55
@moisses89 moisses89 requested a review from a team as a code owner June 12, 2024 11:55
@coveralls
Copy link

Coverage Status

coverage: 87.036% (-0.1%) from 87.16%
when pulling efa6f28 on fix_reload_threeshold
into cc5b9f1 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.011% (-0.1%) from 87.136%
when pulling 70133fb on fix_reload_threeshold
into 29be0a2 on main.

@coveralls
Copy link

Coverage Status

coverage: 86.934% (-0.1%) from 87.033%
when pulling 6ba5670 on fix_reload_threeshold
into bebbba2 on main.

@moisses89 moisses89 merged commit b405271 into main Jun 14, 2024
14 checks passed
@moisses89 moisses89 deleted the fix_reload_threeshold branch June 14, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[change_threshold, tx-service mode] failing tx execution unless refreshing
3 participants