Typo in _all_uniprot #291
Open
Typo in _all_uniprot #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2024 08:23
deeenes
reviewed
Mar 21, 2024
| @@ -343,7 +343,7 @@ def get_uniprot_sec(organism = 9606): | |||
| if _organism: | |||
|
|
|||
| from pypath.inputs import uniprot_db | |||
| proteome = uniprot_db.all_uniprots(organism=organism) | |||
| proteome = uniprot_db._all_uniprots(organism=organism) | |||
There was a problem hiding this comment.
@dbdimitrov Where have you encountered an error from this? As far as I'm aware, this function is called all_uniprots and get_uniprot_sec runs fine for me.
There was a problem hiding this comment.
hmmm, honestly not 100% sure, I believe it was related to map_names
There was a problem hiding this comment.
PS. I just noticed that actually you changed it in a following version.
The issue that I was encountering was in 0.15.13.
Feel free to close if map_names works for you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to biocypher/metalinks#4