[EXPERIMENTAL] Test iframe submission #450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Apr 16, 2024
|
|
||
| // Wait is required to avoid false-positive passes. | ||
| // TODO: replace wait with a more efficient method. | ||
| await new Promise(resolve => setTimeout(resolve, 300)); |
OrKoN
reviewed
Apr 16, 2024
| promise_test(async () => { | ||
| const tree = await test_driver.bidi.browsing_context.get_tree({root: window}); | ||
| const iframe = tree[0].children[0]; | ||
| const submit_button_selector_result = await test_driver.bidi.browsing_context.locate_nodes({ |
There was a problem hiding this comment.
I think the API is nice and I like it very much that you can use window interchangeably with browsingContext
There was a problem hiding this comment.
And the same approach can be used for the element itself vs it's sharedId
sadym-chromium
force-pushed
the
sadym/testdriver-bidi
branch
from
8b261c9 to
5e18b51
Compare
sadym-chromium
force-pushed
the
sadym/frame
branch
from
58ea4d9 to
37c9c24
Compare
extend testdriver bidi with required methods
sadym-chromium
force-pushed
the
sadym/frame
branch
from
37c9c24 to
81e3d50
Compare
|
This looks pretty nice to me, although it does feel like at some point we're going to want a higher level abstraction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extention of web-platform-tests#44649, providing a way to automate iframe sandbox tests. This is a very draft version, and the specific API, especially of the
testdriveris a subject to discuss. Nevertheless, this PR is intended to provide a showcase of how the testdriver BiDi can be used in cases where there is no direct access from the test file to the browsing context under the test.