feat(sdk): integrate bip322-js to sign & verify non-legacy address messages #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR installs & integrates bip322-js lib to sign and verify messages generated using
p2wpkh
,p2sh-p2wpkh
, and single-key-spendp2tr
addresses.bitcoinjs-message only supports
p2pkh
and despite their latest support to segwit, we would like to keep the segregation of libs that are capable to handle and well-designed for a specific purpose.BIP-322 outlines the approach bip322-js follows to enable message signing and verification for non-legacy addresses.