-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): migrate utxo-api API calls to v2 #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, moved types to relevant files
iamcrazycoder
changed the title
feat(sdk): migrate utxo-api API calls to to v2
feat(sdk): migrate utxo-api API calls to v2
Jul 28, 2023
also, replace string w/ specific type
iamcrazycoder
commented
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! (Self-review)
Tested:
- Publish collection (OIP-2)
- Mint inscription
- Standard Inscription (OIP-1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR upgrades the utxo-api API calls to v2. The current version of utxo-api is flaky, unoptimised, and laggy and cannot be trusted for production use. v2 on the other hand has been written from scratch w/ improvements like near-realtime (1-5ms) block sync, JSON-RPC interface via HTTP, bug fixes and several improvements.
Also, a few bug fixes and improvements have been added in this PR.