Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lightslider.js #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update lightslider.js #214

wants to merge 1 commit into from

Conversation

elihorn
Copy link

@elihorn elihorn commented Feb 24, 2016

Meant to address issue noted in #172 where adaptiveHeight compounds height and padding-bottom attributes when in 'fade' mode

First pull request—hope I'm doing it right!

@elihorn
Copy link
Author

elihorn commented Jul 28, 2017

Any reason this hasn't been included yet? Every time I update my libraries I have to go make this fix.

@alexanderkryska
Copy link

Any reason this hasn't been included yet? Every time I update my libraries I have to go make this fix.

I have the same problem. Almost 4 years later, it still fixes this issue! Thank you, @elihorn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elihorn @alexanderkryska @nessthehero