Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust code to make php-cs-fixer and phpstan pass #667

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 28, 2024

The latest php-cs-fixer and phpstan want to make a few changes.

I needed to pin php-cs-fixer to 3.62.0 because of issue PHP-CS-Fixer/PHP-CS-Fixer#8182

After that is fixed, we can probably move to 3.63

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (c14420f) to head (e1cc246).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #667   +/-   ##
=========================================
  Coverage     98.78%   98.78%           
  Complexity     1875     1875           
=========================================
  Files            71       71           
  Lines          5273     5273           
=========================================
  Hits           5209     5209           
  Misses           64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis marked this pull request as ready for review August 28, 2024 09:22
@phil-davis phil-davis merged commit ad1a838 into sabre-io:master Aug 28, 2024
8 checks passed
@phil-davis phil-davis deleted the fix-ci-20240828 branch August 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant