Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker properly handles iTip containing only an updated occurrence. F… #366

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ddolcimascolo
Copy link
Contributor

…ixes #365

foreach ($existingObject->getComponents() as $component) {
$existingObject->remove($component);
if ($component->name !== 'VEVENT') {
$existingObject->remove($component);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering out loud: is this needed? Should we get rid of VTIMEZONE ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wondered too while reading the code.
Previously VTIMEZONE components were also removed, and added back from the iTip.

I'm fine reworking this to only remove and add VEVENT components. Let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants