Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return png images as G or GA instead of RGBA? #76

Open
perlman opened this issue Jan 31, 2018 · 3 comments
Open

Return png images as G or GA instead of RGBA? #76

perlman opened this issue Jan 31, 2018 · 3 comments
Assignees

Comments

@perlman
Copy link
Collaborator

perlman commented Jan 31, 2018

Some endpoints, e.g. /png-image, return data as RGBA (specifically, "PNG image data, 1024 x 1024, 8-bit/color RGBA, non-interlaced").

I am considering adding flags to force grayscale and/or disable transparency for PNG output. (The PNG format supports both G and GA at both 8- and 16-bit depths.)

Is this a reasonable approach?

@perlman perlman self-assigned this Jan 31, 2018
@perlman
Copy link
Collaborator Author

perlman commented Jan 31, 2018

@trautmane
Copy link
Collaborator

Hi Eric,
Apologies for my delayed response.
This looks reasonable to me - kudos for digging into the https://github.com/leonbloy/pngj library details.
Did it work for you?
-- Eric T.

@perlman
Copy link
Collaborator Author

perlman commented Feb 14, 2018

The 16-bit grayscale PNG output is working well.

I have not touched 8-bit output yet. I don't want to break RGBA support for those that use it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants