Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N5FSReader doesn't throw IOException if basePath does not exist #89

Open
cmhulbert opened this issue Nov 14, 2022 · 1 comment
Open

N5FSReader doesn't throw IOException if basePath does not exist #89

cmhulbert opened this issue Nov 14, 2022 · 1 comment

Comments

@cmhulbert
Copy link
Contributor

cmhulbert commented Nov 14, 2022 •
edited
Loading

The docstring for N5FSReader indicates that:

* @throws IOException
* if the base path cannot be read or does not exist,
* if the N5 version of the container is not compatible with this
* implementation.

However the constructor returns a valid N5FSReader when the basePath does not exist. This delays the error to the first read of the N5 container, instead of at construction
cmhulbert added a commit that referenced this issue Dec 22, 2022
@cmhulbert
fix: N5FSReader should fail if base path does not exist (#89)
a81cfc4
cmhulbert added a commit that referenced this issue Jan 3, 2023
@cmhulbert
feat: inline createDirectories now that non-existent path throws IOEx…
c1abdfc 
…ception during reader construction (#89)
@bogovicj bogovicj mentioned this issue Feb 13, 2023
Closed
@cmhulbert
Copy link
Contributor Author

PR #91 aligns the logic of the N5Reader with the documentation, however the current behavior allows creation of N5Reader on non-existent directories, so this is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmhulbert