Merge pull request #287 from gnbm/IssueSelectAll

Fix issue with selectAllOnlyVisible and empty filtered list
sa-si-dev · Dec 28, 2023 · 63b1be0 · 63b1be0
2 parents 8edea0e + f120107
commit 63b1be0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/virtual-select.js b/src/virtual-select.js
@@ -2550,8 +2550,10 @@ export class VirtualSelect {
       isAllSelected = this.isAllOptionsSelected();
     }
 
-    /** when all options not selected, checking if all visible options selected */
-    if (!isAllSelected && this.selectAllOnlyVisible) {
+    /** when all options not selected, checking if all visible options selected 
+     *  Also, in a search mode, validate that we still have visible items
+    */
+    if (!isAllSelected && this.selectAllOnlyVisible  && (this.searchValue !== '' && this.visibleOptionsCount > 0 || this.searchValue == '')) {
       isAllVisibleSelected = this.isAllOptionsSelected(true);
     }