Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented CBasePlayerWeapon::KickBack hook #738

Closed
wants to merge 5 commits into from
Closed

Implemented CBasePlayerWeapon::KickBack hook #738

wants to merge 5 commits into from

Conversation

ShadowsAdi
Copy link
Contributor

And fixed compilation warning in weapons.cpp -> GetBaseAccuracy()

Related to rehlds/reapi#153
https://dev-cs.ru/threads/1056/page-13#post-122698

@ShadowsAdi
Implemented CBasePlayerWeapon::KickBack hook
bb3484a 
and fixed compilation warning in weapons.cpp -> GetBaseAccuracy()
@StevenKal
Copy link
Contributor

New hooks in end of the list, always!

@ShadowsAdi
Copy link
Contributor Author

ShadowsAdi commented Mar 19, 2022 •
edited
Loading

Hm, you're right, gotta change that.
Edit: Tested it. It works without any problems.

@StevenKal
Copy link
Contributor

StevenKal commented Mar 19, 2022 •
edited
Loading

The following functions after it are broken, except if you recompile ReAPI module too with new IDs, and use it.
But for people who will have "the "ReGameDLL_CS with your kickback hook", and still having old ReAPI, and, using the functions being after it (DropIdlePlayer, etc.), this will be broken, because virtual IDs will not match & point to wrong function.

@dystopm dystopm mentioned this pull request Jul 16, 2023
Merged
@s1lentq
Copy link
Owner

s1lentq commented Sep 5, 2023

Done #849

@s1lentq s1lentq closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wopox1337 wopox1337 wopox1337 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShadowsAdi @StevenKal @s1lentq @wopox1337