Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Added new API funcs #1008

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lozatto
Copy link

@lozatto lozatto commented Aug 30, 2024

No description provided.

@dystopm
Copy link
Contributor

dystopm commented Aug 30, 2024

I think most of them are a great addition and will help more than one coder, BTW I got some observations:

  • There are functions here that are already exported. I must remind you that the ReGame API is not the only interface that is exported here: enginefuncs_t includes SetSize, SetOrigin, PointContents and FindEntityInSphere. I don't see the point in adding them redundantly.
  • UTIL_CountEntities is a miscellaneous one (did myself) and can be done in any metamod/amxx subplugin even without using regame. There's a NEED in exporting them?
  • Are you aware that UTIL_IsSpawnPointOccupied is bugged and is also not being used? 👀 (it needs NOXREF tag also) (VEC_SPOT_HULL_MIN/MAX vectors are not considering negative height)

EDIT: I'm quoting @wopox1337 here:

Just use Hamsandwich, there will be no difference in performance. your requests for code convenience are strange, all your problems are completely solvable without reapi and code complications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants