Add augmentation methods for SBCL client #26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables proclaimed SB-EXT:GLOBAL were not being looked up outside of the lexical environment, i.e., via SB-INT:INFO. SBCL actually signals an error when lexically binding an SB-EXT:GLOBAL variable, so I do not know how it can be possible to look one up in the lexical environment, but that is what SB-CLTL2:VARIABLE-INFORMATION does. The type, always-bound and deprecated information was not being filled in for global variables. Finally, the always-bound-mixin and deprecated-mixin classes were being mixed into some description classes that cannot ever be always-bound or deprecated. The SBCL manual states that the always-bound declaration is valid only as a global proclamation [1], so local variables cannot be thus declared. Although it does not mention it explicitly [2], deprecated declarations must also be global proclamations (SBCL signals warnings for both otherwise). Some experimentation on my part showed that local special variables do not carry over the always-bound and deprecated information from their global counterparts. Constant variables and global symbol macros cannot be always-bound either, as demonstrated by the following code: (defconstant +%test-constant+ nil) (declaim (sb-ext:always-bound +%test-constant+)) (define-symbol-macro +%test-symbol-macro+ nil) (declaim (sb-ext:always-bound +%test-symbol-macro+)) This commit looks up SB-EXT:GLOBAL variables outside of the lexical environment, fill in the type, always-bound and deprecated information in DESCRIBE-VARIABLE where missing, removes ALWAYS-BOUND-MIXIN from the superclasses of all variable description classes except GLOBAL-SPECIAL-VARIABLE-DESCRIPTION and GLOBAL-VARIABLE-DESCRIPTION, and removes DEPRECATED-MIXIN from the superclasses of LEXICAL-VARIABLE-DESCRIPTION, LOCAL-SPECIAL-VARIABLE-DESCRIPTION and LOCAL-SYMBOL-MACRO-DESCRIPTION. [1]: http://www.sbcl.org/manual/#Global-and-Always_002dBound-variables [2]: http://www.sbcl.org/manual/#Deprecation-Declaration
Bring it in line with SB-CLTL2:FUNCTION-INFORMATION (which might have been updated since the last time DESCRIBE-FUNCTION was updated). Added compiler-macro and deprecated information where applicable, and cleaned up the global ftype from any SBCL-specific representation by calling SB-KERNEL:TYPE-SPECIFIER on it. Removed DEPRECATED-MIXIN from superclasses of LOCAL-FUNCTION-DESCRIPTION and LOCAL-MACRO-DESCRIPTION (see previous commit for explanation).
Also overhaul the test suite to allow for the newly added augmentation tests.
paulapatience
force-pushed
the
add-sbcl-augmentation-methods
branch
from
3e62105
to
e5c5485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.