Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/tos: updated docs #720

Merged
merged 2 commits into from
Dec 4, 2023
Merged

feature/tos: updated docs #720

merged 2 commits into from
Dec 4, 2023

Conversation

ugolino
Copy link
Contributor

@ugolino ugolino commented Nov 29, 2023

Task: RYSK-624

Description

update docs

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document update
  • Quality of life improvement
  • Package upgrades

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have NATSPEC'd any new functions
  • If appropriate, I have properly tested my new functionality

@MeanBoyCousin
Copy link
Contributor

MeanBoyCousin commented Nov 30, 2023 •
edited
Loading

Noticed you changed this email elsewhere to privacy. Does this one need doing as well? Also in section 7.1 of ToS.
image

MeanBoyCousin
MeanBoyCousin approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@MeanBoyCousin MeanBoyCousin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise. Did a text search of the actual pages but still using Rysk in a lot of places so I will defer to legal on the actual copy.

@ugolino ugolino merged commit f1b20b8 into production Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeanBoyCousin MeanBoyCousin MeanBoyCousin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ugolino @MeanBoyCousin