Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add support to store multiple commands in NFC card #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat:add support to store multiple commands in NFC card #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/sonos_nfc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ const sonos_nfc = (nfc) => {
case 'text':
const received_text = record.text;
console.log('Read from NFC tag with message: ', received_text);
// splt lines to accommodate for multiple commands
var lines = received_text.split("\n");
console.log('Lines read from NFC tag: ', lines);

for (const command of lines) {
await process_sonos_command(command);
}

await process_sonos_command(received_text);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this call is redundant (in the case of a single line) and an error (in the event of multiple lines.

}
Expand Down