Initial conversion to objc2
#30
Conversation
|
Alright, #29 is merged and done... albeit through some extra steps because I am of the idiot clan tonight. You should be able to rebase this onto trunk cleanly (ish) now. Thanks again for all your work! |
|
Wonderful, no worries about the merge mistake, happens to the best of us ;) This PR is fairly close to serviceable now (just need to do a new release of some things in Note that we're currently getting a lot of deprecation warnings, will fix those in a subsequent PR. |
|
Cool, excited! |
Cargo.toml
Outdated
| # Temporary: Patched versions that implement `Encode` for common types | ||
| # Branch: `objc2` | ||
| core-foundation = { git = "https://github.com/madsmtm/core-foundation-rs.git", rev = "c506e7d70da010c0070048e9471ff0b441506e65", features = ["with-chrono"] } | ||
| core-graphics = { git = "https://github.com/madsmtm/core-foundation-rs.git", rev = "c506e7d70da010c0070048e9471ff0b441506e65" } |
There was a problem hiding this comment.
A possible fix for these is #35
|
I'll find time later this week (or this weekend) to review - I've been at a racing thing for most of the beginning of this week and am exhausted by the time I sit down to my laptop at night. :( Really excited for this though! Your work is super appreciated. |
|
No problem, take all the time you need - I'm just enjoying my summer holidays, have lots of other things to distract me with ;) |
|
I am comfortable merging this one whenever makes sense - I want to merge #48 soon, but I'm thinking it might be smarter to get the I'd be fine with using the (Aside: |
|
(slash, could you rebase this onto |
|
Just do #48 first, I'm gonna be away for a few days so I won't have time for this before around Friday. Re beta series, I'm fairly certain I know where I want |
|
Okay, I've rebased this now, thanks for your patience! |
madsmtm
force-pushed
the
objc2
branch
2 times, most recently
from
3fdc19f to
87fe0e3
Compare
|
I haven't forgotten about this - last I checked in on it, I had a few examples crash and I need to look into why. I get the sense it's probably small stuff but I've just been too busy to sit down and poke at it. (Hoping I have time this weekend tho since I'll be mostly chilling at home) |
|
Sounds good, appreciate it!
…On Mon, Aug 22, 2022 at 01:35, Mads Marquart ***@***.***> wrote:
Just do [#48](#48) first, I'm gonna be away for a few days so I won't have time for this before around Friday.
Re beta series, I'm fairly certain I know where I want objc2 to end up for a stable 0.3, [the milestone](https://github.com/madsmtm/objc2/milestone/1) should be fairly accurate and in order now, it's just a matter of actually finishing implementing it. I expect it to take maybe two months in total, and I think this is a fairly accurate assessment, but yeah, anything can happen.
—
Reply to this email directly, [view it on GitHub](#30 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAFROFZWZZCNQI2FRDLDCTV2M3UPANCNFSM53FLUREQ).
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Appreciate the breakdown, makes sense to me.
And no worries - I actually feel bad for how long this has sat so definitely looking forward to merging it. Will give it one last once over tomorrow and we should be good I think.
…On Tue, Aug 1, 2023 at 04:55, Mads Marquart ***@***.***(mailto:On Tue, Aug 1, 2023 at 04:55, Mads Marquart <<a href=)> wrote:
>> which needs a lot of work in cacao to avoid runtime errors (actually it'll just be fixing soundness bugs, but it'll still be work).
>
> Hmmm, can you give me an example? Mostly just looking to make sure I'm following along here.
Okay, so objc2 requires all arguments and return types to implement the special trait Encode, which ensures that the types are not accidentally things that don't have a stable ABI, like Vec<u8> or &str. That's being done in this PR, and already helps a lot with soundness.
But, every method in Objective-C also has the types it takes available in the runtime (somewhat limited, e.g. generics are not available, but still), and we take advantage of that to check, when debug assertions are enabled, whether the type on the Rust side matches what's declared on the Objective-C side.
An example of an error thrown by this could be the following (the issue: the code is setBorderType: 0, which means the type of the integer falls back to i32, while the function expects a NSBorderType (which is NSUInteger (which is usize))):
> thread 'scrollview::test_scrollview' panicked at 'invalid message send to -[RSTScrollView_NSScrollView_13638830006937841139 setBorderType:]: expected argument at index 0 to have type code 'Q', but found 'i'', src/scrollview/mod.rs:89:25
Of course in this process, there are many false positives (and I actually recently [implemented](madsmtm/objc2#478) something to reduce that rate, making transitions easier), like the following (the issue: an object pointer nil is being passed as the action, even though a selector is expected, which is valid ABI-wise, but confusing to the type-system).
> thread 'button::test_button' panicked at 'invalid message send to +[RSTButton_NSButton_9287538210046046270 buttonWithTitle:target:action:]: expected argument at index 2 to have type code ':', but found '@'', src/button/mod.rs:127:30
---------------------------------------------------------------
> I wanted to get [#89](#89) in for a 0.4 release, but alas I did invoke two merge conflicts here as a result. They're small and if you don't have time for them I can look into them once I get the 0.5 pieces going, but you have my word that your PR is next. :)
No worries, it's just troublesome if I have multiple PRs that need to be rebased on top of each other, and I was a bit tired and grumpy yesterday ;).
—
Reply to this email directly, [view it on GitHub](#30 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAFROGG4TOE7KQBYUFB4E3XTDVE5ANCNFSM53FLUREQ).
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
See madsmtm/objc2#150 for a bit of background
This is something we'll need to look into properly
Safer and more ergonomic. Also required for `msg_send_id!` macro
This makes cacao compile on Aarch64 again
These consumed `self`, and hence also dropped `Id` variable that was responsible for keeping the returned pointer alive
|
Okay, so I went over the examples, and fixed the memory safety issues I could find by running those. That said, there are probably still more that I haven't found yet, but I feel like it's at a pretty good stage! Note to self: The following is really useful for debugging double-frees and such: DYLD_INSERT_LIBRARIES=/usr/lib/libgmalloc.dylib MallocStackLogging=YES NSZombieEnabled=YES MallocGuardEdges=YES MallocScribble=YES ./target/debug/examples/my_example |
|
Merged. :) Thank you again for the sheer amount of work here, as well as for the wider ObjC work you're doing in the Rust community. It's really great that someone's picked up the torch and focused on making it all safer and more reliable overall. I'll let this sit in trunk for a bit to see how people find it - whether we need to fix any bugs or anything - but then if all seems fine I'll eye pushing out the next ( |
|
Perfect! I think before you can push a beta, we'll need to stop relying on the |
|
Yup, no rush! |
|
FYI: #122 |
Blocked on #29. Part of #28.An initial pass of just getting things to compile. Upgrade instructions for most of the breaking changes can be found in
objc2's CHANGELOG, I've essentially just done as instructed by the examples there.