Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANIFEST.in: Add tests #33

Merged
merged 3 commits into from
Mar 10, 2019
Merged

MANIFEST.in: Add tests #33

merged 3 commits into from
Mar 10, 2019

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Mar 10, 2019

Closes #32

@ryanhiebert
Copy link
Owner

Thanks, I need to drop 3.3 to make travis happy.

I'm curious about your thoughts on a similar matter. In my application code, I prefer to colocate my unit tests, which I learned to do writing react/just, and I really like. It feels wrong to have unit tests in the distributed package, though, because they aren't part of the interface I'm publishing.

I know that some distributors require tests in at least the sdist, but that seems like it's limited to source distributions, not wheels. Do you think having tests included in the wheels is good? Collating tests is good IMO, but I don't know how to get them out of the wheel if I do. Not that any of this applies to this package, it just got my mind wondering

@ryanhiebert
Copy link
Owner

I fixed the tests without dropping support for any tested versions. Sweet.

@ryanhiebert ryanhiebert merged commit 200de0b into ryanhiebert:master Mar 10, 2019
@jayvdb
Copy link
Contributor Author

jayvdb commented Mar 11, 2019

@ryanhiebert , moving this over to moremoban/pypi-mobans#78 , which is a cookie-cutter-like system I've been working on. The recipe we come up with would be re-usable anywhere, i.e. without moban.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants