attach drag behaviour to event rectangle #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wflemingnz-retired
requested changes
Feb 26, 2020
| }; | ||
| } | ||
|
|
||
| private shiftDraggedTimelineEvent( |
There was a problem hiding this comment.
Suggested change
| private shiftDraggedTimelineEvent( | |
| private updateDraggedTimelineEvent( |
| repeat() | ||
| ); | ||
|
|
||
| onDrag(eventRectangle: EventRectangle, event: any) { |
There was a problem hiding this comment.
Suggested change
| onDrag(eventRectangle: EventRectangle, event: any) { | |
| onDrag(eventRectangle: EventRectangle, event: EventRectangleDragEvent) { |
|
|
||
| private setupDrag() { | ||
| if (this.eventRectangleEl) { | ||
| const onDrag = drag() |
There was a problem hiding this comment.
can we use https://rxjs.dev/api/index/function/fromEventPattern in some way here?
There was a problem hiding this comment.
Good find, although I'm not sure that it will simplify the code.
There was a problem hiding this comment.
I've created an issue to investigate #118
There was a problem hiding this comment.
yeah not sure either, could be worth keeping it in mind. I used it for a Titan related POC to hook into the map events (I think).
| scan( | ||
| (acc, curr) => | ||
| curr ? { ...curr, dy: acc.dy + curr.dy, dx: acc.dx + curr.dx } : acc, | ||
| { |
There was a problem hiding this comment.
could declutter this observable/scan by declaring the initial value in its own variable ie:
const dragSeed = {
dx: 0,
dy: 0,
id: null
}
projects/ngx-d3timeline/src/lib/content/event-rectangle.component.spec.ts
Show resolved
Hide resolved
wflemingnz-retired
approved these changes
Feb 26, 2020
…line into 114-attach-drag-behaviour-to-event-rectangle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #114