Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LmDataset get_total_num_seqs #1442

Merged
merged 1 commit into from
Oct 21, 2023
Merged

LmDataset get_total_num_seqs #1442

merged 1 commit into from
Oct 21, 2023

Conversation

albertz
Copy link
Member

@albertz albertz commented Oct 21, 2023

Should fix #1441.

Also:

CachedDataset2 num_seqs 0 if not initialized.
CachedDataset2 is_less_than_num_seqs same.

Dataset have_seqs more correct.

Should fix #1441

Also:

CachedDataset2 num_seqs 0 if not initialized.
CachedDataset2 is_less_than_num_seqs same.

Dataset have_seqs more correct.
@albertz albertz requested a review from a team as a code owner October 21, 2023 10:27
@albertz albertz merged commit e3c0303 into master Oct 21, 2023
@albertz albertz deleted the albert-dataset-lm-fix-1441 branch October 21, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LmDataset: Not a single seq was loaded
1 participant