Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensor copy_transpose simplify #1413

Merged
merged 5 commits into from
Oct 7, 2023
Merged

Tensor copy_transpose simplify #1413

merged 5 commits into from
Oct 7, 2023

Conversation

albertz
Copy link
Member

@albertz albertz commented Oct 6, 2023 •
edited
Loading

For raw integers, directly use transpose_raw.
For dim tags, use copy_compatible_to_dims.

Along the way, in Tensor.copy_compatible_to_dims, the logic for feature_dim_axis and time_dim_axis with version == 1 was slightly changed, to follow what the old Tensor.copy_transpose was doing.

@albertz
Tensor copy_transpose simplify
e1175c8 
For raw integers, directly use transpose_raw.
For dim tags, use copy_compatible_to_dims.
@albertz albertz requested a review from a team as a code owner October 6, 2023 22:15
@albertz albertz mentioned this pull request Oct 6, 2023
Open
45 tasks
@albertz albertz merged commit f1a678f into master Oct 7, 2023
@albertz albertz deleted the albert-simplified-transpose branch October 7, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@albertz