Data same_dim_tags_as fix auto_create_placeholders #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't first create a new size placeholder and then later call declare_same_as. Esp this is required when declare_same_as becomes stricter (#1143).
The dim tag could have an old invalid batch info. E.g. the global batch_dim when it comes from an old run. If we really need this, we should validate the dim tag first. But probably it's better to remove it and clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't first create a new size placeholder and then later call
declare_same_as.Esp this is required when
declare_same_asbecomes stricter (#1143).