Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotLayer fix incorrect dim matching #1155

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Conversation

albertz
Copy link
Member

@albertz albertz commented Oct 19, 2022

Fix #1154.

Fix rwth-i6/returnn_common#227.

Introduces a new behavior version (#508).

@albertz
Copy link
Member Author

albertz commented Oct 19, 2022

Oh, I would have expected that this change causes some other tests to fail, but it does not seem so. Probably because most older setups explicitly set var1 and var2 in the dot layer, and those are not affected by this change.

@albertz albertz marked this pull request as ready for review October 19, 2022 12:56
@albertz albertz requested a review from a team as a code owner October 19, 2022 12:56
@albertz albertz merged commit e8c365e into master Oct 19, 2022
@albertz albertz deleted the albert-dot-layer-diff-dim-fix branch October 19, 2022 12:57
albertz added a commit to rwth-i6/returnn_common that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant