Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Core::FIFOCache #79
base: master
Are you sure you want to change the base?
Add Core::FIFOCache #79
Changes from 1 commit
58bda79
fbbe72c
54c175a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This throws an exception if the key is not present. As nobody ever catches these it will probably terminate the application. I think it would be better to return
std::optional<Value&>
and for an interface the default-constructs the value add anoperator[]
function.For the version returning
std::optional<Value&>
we could also have a const version of the function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ unfortunately doesn't support optional references so
std::optional<Value&>
doesn't work . I have implemented this now by usingstd::optional<std::reference_wrapper<Value>>
. It could also be done by usingValue*
as return value instead and returningnullptr
when the key is not found.