-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend feature extraction module to allow for RASR compatible logmel features #40
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0c7bb2f
extend feature extraction
kuacakuaca 91e8e0b
restore names
kuacakuaca 1559a09
reorder
kuacakuaca e3101cf
fix type annotations, add shape annotations
kuacakuaca cf72c0a
fix
kuacakuaca 221a813
fix typo
kuacakuaca f24d0c3
Merge branch 'main' of https://github.com/rwth-i6/i6_models into exte…
kuacakuaca cfb3f56
pass mel filter parameters directly & make spectrum type enum & fix l…
kuacakuaca f1f8081
add else branches
kuacakuaca 7bd8e6c
better error message
kuacakuaca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we agreed on not setting any defaults unless it is immediately obvious that that should be a default or for "structural parts"
But I now wonder that the original values had no defaults and what you add does. (Wich is required, I understand, to keep backwards compatibility - But then did we not agree to deprecate the old class and create a new one V2 in cases like this?)
Do we actually need to configure all this? Or are there ever only 2 sets of parameters that are going to be used? ("default", "rasr-compatible"). Is then not a better choice to have a single parameter for "default" vs. "rasr-compatible" that then sets all of these never otherwise touched parameters to the appropriate values?
And if the answer is yes, would it not rather make sense in this case to do create a new class - but not
LogMelFeatureExtractionV2
but insteadRasrCompatibleLogMelFeatureExtractionV1
..? (and then we have no config options, just the two classes do use the correct thing)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh well 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the defaults are problematic here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not the defaults that are problematic, but adding new parameter automatically breaks setups. I will revert the PR. And then I would be in favor of Willis RasrCompatibleLogMelFeatureExtraction instead of the V2. But I would be fine with both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does adding parameters with default values break anything?
Edit See discussion in #41 about that.