feat/typegraphql #86
Merged
feat/typegraphql #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rwieruch
commented
Apr 19, 2020
rwieruch
commented
- use TypeGraphQL instead of Apollo Schema + GraphQL Code Gen (server)
rwieruch
commented
Apr 19, 2020
| @@ -1,14 +1,6 @@ | |||
| schema: http://localhost:3000/api/graphql | |||
|
|
|||
| generates: | |||
| src/generated/server.ts: | |||
There was a problem hiding this comment.
- remove server graphql code gen in favor of TypeGraphQL
rwieruch
commented
Apr 19, 2020
| useIndexSignature: true | ||
| plugins: | ||
| - typescript | ||
| - typescript-resolvers | ||
| src/generated/client.tsx: |
There was a problem hiding this comment.
- keep using client graphql code gen for React Hooks etc.
rwieruch
commented
Apr 19, 2020
| @@ -47,12 +46,13 @@ | |||
| "b64-to-blob": "^1.2.19", | |||
| "babel-plugin-import": "^1.13.0", | |||
| "babel-plugin-inline-import": "^3.0.0", | |||
| "babel-plugin-transform-typescript-metadata": "^0.3.0", | |||
| "class-validator": "^0.11.1", | |||
There was a problem hiding this comment.
rwieruch
commented
Apr 19, 2020
| @@ -84,10 +84,12 @@ | |||
| "reflect-metadata": "^0.1.13", | |||
| "stripe": "^8.7.0", | |||
| "styled-components": "^5.0.0", | |||
| "type-graphql": "^0.18.0-beta.16", | |||
There was a problem hiding this comment.
- beta usage here, because 0.17 had issues with hot reloading Getting "Schema must contain uniquely named types but contains multiple types named" for a single type MichalLytek/type-graphql#396 (comment)
rwieruch
commented
Apr 19, 2020
| "dotenv": "^8.2.0", | ||
| "file-saver": "^2.0.2", | ||
| "firebase": "^7.7.0", | ||
| "firebase-admin": "^8.9.1", | ||
| "graphql": "^14.5.8", | ||
| "graphql-iso-date": "^3.6.1", |
rwieruch
commented
Apr 19, 2020
| const server = new ApolloServer({ | ||
| schema, | ||
| context: async ({ req, res }): Promise<ResolverContext> => { | ||
| const me = await getMe(req, res); |
There was a problem hiding this comment.
- bonus: changed into middleware
rwieruch
commented
Apr 19, 2020
| @@ -41,11 +49,15 @@ export const config = { | |||
| export default async (req: ServerRequest, res: ServerResponse) => { | |||
| const connection = await getConnection(); | |||
|
|
|||
| const schema = await buildSchema({ | |||
| resolvers, | |||
| dateScalarMode: 'isoDate', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.