Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to create stand-alone docker instance #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eibwen
Copy link

@Eibwen Eibwen commented Sep 7, 2015

Made a dockerfile to configure this. It runs both redis and node in the same docker instance (which is not the recommended way of using docker, but for such a simple app that is never going to get much load is not an issue)

(didn't realize github will append other commits on same branch to an existing pull request, so sorry for this second request after i deleted the first)

@crccheck
Copy link

I'm not sure if the Dockerfile should have redis in it. My choice would have been to only do the bot based on the official node base box and documentation showing how to link to the official redis docker image. In fact, now that I think about it, I don't like doing both in one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants